Skip to content

NIFI-9631 enable the nifi-toolkit cli.sh to be used with a symbolic link#5717

Closed
westdart wants to merge 1 commit intoapache:mainfrom
westdart:main
Closed

NIFI-9631 enable the nifi-toolkit cli.sh to be used with a symbolic link#5717
westdart wants to merge 1 commit intoapache:mainfrom
westdart:main

Conversation

@westdart
Copy link
Contributor

@westdart westdart commented Jan 26, 2022

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables nifi-toolkit cli.sh to be invoked through a symbolic link

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message? NIFI-9631

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@westdart westdart changed the title enable the nifi-toolkit cli.sh to be used with a symbolic link NIFI-9631 enable the nifi-toolkit cli.sh to be used with a symbolic link Jan 26, 2022
@thenatog
Copy link
Contributor

thenatog commented Feb 3, 2022

Tested and looks good, +1 will merge

@thenatog thenatog closed this in 11bad7b Feb 3, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes apache#5717.
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes apache#5717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants