NIFI-9655 Add Queue Logging to ListenUDP#5747
Merged
markap14 merged 2 commits intoapache:mainfrom Feb 4, 2022
Merged
Conversation
- Added TrackingLinkedBlockingQueue to track the largest queue size - Updated AbstractListenEventProcessor to write debug log at most once per minute - AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
9abebe6 to
20c476b
Compare
Contributor
|
Tested the log and saw it appearing every 60 seconds. +1 from me |
Contributor
|
Looks good to me too. Thanks for improving that! +1 merged to main |
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
* NIFI-9655 Added Queue Logging to ListenUDP - Added TrackingLinkedBlockingQueue to track the largest queue size - Updated AbstractListenEventProcessor to write debug log at most once per minute - AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
* NIFI-9655 Added Queue Logging to ListenUDP - Added TrackingLinkedBlockingQueue to track the largest queue size - Updated AbstractListenEventProcessor to write debug log at most once per minute - AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
NIFI-9655 Adds queue size debug logging to
ListenUDPandListenUDPRecordthrough updates to theAbstractListenEventProcessor.The debug logging occurs at most once per minute. The implementation uses an
AtomicLongto track the minimum next timestamp in milliseconds for logging, and relies on processor scheduling for logging invocation. This approach avoids running an additional thread for background logging, and expects that the processor will be scheduled more often than 60 second intervals. The implementation leverages a customTrackingLinkedBlockingQueueto maintain the largest queue size over the lifecycle of the processor. Restarting the processor resets the queue and associated largest queue size tracking.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.