Skip to content

NIFI-9655 Add Queue Logging to ListenUDP#5747

Merged
markap14 merged 2 commits intoapache:mainfrom
exceptionfactory:NIFI-9655
Feb 4, 2022
Merged

NIFI-9655 Add Queue Logging to ListenUDP#5747
markap14 merged 2 commits intoapache:mainfrom
exceptionfactory:NIFI-9655

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9655 Adds queue size debug logging to ListenUDP and ListenUDPRecord through updates to the AbstractListenEventProcessor.

The debug logging occurs at most once per minute. The implementation uses an AtomicLong to track the minimum next timestamp in milliseconds for logging, and relies on processor scheduling for logging invocation. This approach avoids running an additional thread for background logging, and expects that the processor will be scheduled more often than 60 second intervals. The implementation leverages a custom TrackingLinkedBlockingQueue to maintain the largest queue size over the lifecycle of the processor. Restarting the processor resets the queue and associated largest queue size tracking.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Added TrackingLinkedBlockingQueue to track the largest queue size
- Updated AbstractListenEventProcessor to write debug log at most once per minute
- AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
@thenatog thenatog self-requested a review February 4, 2022 22:27
@thenatog
Copy link
Contributor

thenatog commented Feb 4, 2022

Tested the log and saw it appearing every 60 seconds. +1 from me

@markap14 markap14 merged commit bab4309 into apache:main Feb 4, 2022
@markap14
Copy link
Contributor

markap14 commented Feb 4, 2022

Looks good to me too. Thanks for improving that! +1 merged to main

krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
* NIFI-9655 Added Queue Logging to ListenUDP

- Added TrackingLinkedBlockingQueue to track the largest queue size
- Updated AbstractListenEventProcessor to write debug log at most once per minute
- AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
* NIFI-9655 Added Queue Logging to ListenUDP

- Added TrackingLinkedBlockingQueue to track the largest queue size
- Updated AbstractListenEventProcessor to write debug log at most once per minute
- AbstractListenEventProcessor updates support both ListenUDP and ListenUDPRecord
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants