[NIFI-9554] Support building and running NiFi on arm64 platforms and consume nifi-fds 0.3.0#5751
Closed
scottyaslan wants to merge 5 commits intoapache:mainfrom
Closed
[NIFI-9554] Support building and running NiFi on arm64 platforms and consume nifi-fds 0.3.0#5751scottyaslan wants to merge 5 commits intoapache:mainfrom
scottyaslan wants to merge 5 commits intoapache:mainfrom
Conversation
update linting update font awesome path bump nifi-fds version update nifi deps
c0d513d to
c3e3639
Compare
Contributor
|
Thanks @scottyaslan! I can test the arm64 build as well as the functionality testing of a running nifi for various scenarios (cluster, standalone, secure, unsecure, etc). |
Contributor
|
Reviewing... |
mtien-apache
approved these changes
Feb 8, 2022
Contributor
mtien-apache
left a comment
There was a problem hiding this comment.
LGTM! 👍🏼 I was able to run a full build with mvn clean install, tested nifi-registry in dev mode, nifi-registry frontend tests pass, and confirmed the app is consuming nifi-fds 0.3.0
Change npm cache restore keys so that we will not use cached directories for older versions of node.
Contributor
|
So far, so good for me on this PR, but the CI build is not happy. I just made a commit to add a node version to the cache keys for the GHA npm modules cache we use, so let's see if that fixes the builds |
kevdoran
approved these changes
Feb 14, 2022
Contributor
kevdoran
left a comment
There was a problem hiding this comment.
+1 from my end after functional testing. Thanks a lot for this work @scottyaslan! merging to main
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
update lintin update font awesome path bump nifi-fds version update nifi deps update frontend maven plugin change CI npm cache restore keys so that we will not use cached directories for older versions of node This closes apache#5751. Signed-off-by: Kevin Doran <kdoran@apache.org>
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
update lintin update font awesome path bump nifi-fds version update nifi deps update frontend maven plugin change CI npm cache restore keys so that we will not use cached directories for older versions of node This closes apache#5751. Signed-off-by: Kevin Doran <kdoran@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Nifi and Nifi registry apps and dev modes should run as before while consuming nifi-fds 0.3.0 and upgrades to use node v16.13.2. Build and run both applications in both production and developer mode and ensure they are running as intended. All nifi-registry unit tests should pass.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.