Skip to content

[NIFI-9554] Support building and running NiFi on arm64 platforms and consume nifi-fds 0.3.0#5751

Closed
scottyaslan wants to merge 5 commits intoapache:mainfrom
scottyaslan:NIFI-9554
Closed

[NIFI-9554] Support building and running NiFi on arm64 platforms and consume nifi-fds 0.3.0#5751
scottyaslan wants to merge 5 commits intoapache:mainfrom
scottyaslan:NIFI-9554

Conversation

@scottyaslan
Copy link
Contributor

@scottyaslan scottyaslan commented Feb 8, 2022

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Nifi and Nifi registry apps and dev modes should run as before while consuming nifi-fds 0.3.0 and upgrades to use node v16.13.2. Build and run both applications in both production and developer mode and ensure they are running as intended. All nifi-registry unit tests should pass.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

update linting

update font awesome path

bump nifi-fds version

update nifi deps
@kevdoran kevdoran self-requested a review February 8, 2022 15:13
@kevdoran
Copy link
Contributor

kevdoran commented Feb 8, 2022

Thanks @scottyaslan! I can test the arm64 build as well as the functionality testing of a running nifi for various scenarios (cluster, standalone, secure, unsecure, etc).

@mcgilman mcgilman self-requested a review February 8, 2022 16:27
@rfellows
Copy link
Contributor

rfellows commented Feb 8, 2022

Reviewing...

Copy link
Contributor

@mtien-apache mtien-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼 I was able to run a full build with mvn clean install, tested nifi-registry in dev mode, nifi-registry frontend tests pass, and confirmed the app is consuming nifi-fds 0.3.0

Copy link
Contributor

@rfellows rfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I found a few unrelated issues and logged them (NIFI-9658 && NIFI-9659)

Tested both nifi and registry.

Change npm cache restore keys so that we will not use cached directories for older versions of node.
@kevdoran
Copy link
Contributor

So far, so good for me on this PR, but the CI build is not happy. I just made a commit to add a node version to the cache keys for the GHA npm modules cache we use, so let's see if that fixes the builds

Copy link
Contributor

@kevdoran kevdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my end after functional testing. Thanks a lot for this work @scottyaslan! merging to main

@kevdoran kevdoran closed this in b8ec6d3 Feb 14, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
update lintin
update font awesome path
bump nifi-fds version
update nifi deps
update frontend maven plugin
change CI npm cache restore keys so that we will not use cached directories for older versions of node

This closes apache#5751.

Signed-off-by: Kevin Doran <kdoran@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
update lintin
update font awesome path
bump nifi-fds version
update nifi deps
update frontend maven plugin
change CI npm cache restore keys so that we will not use cached directories for older versions of node

This closes apache#5751.

Signed-off-by: Kevin Doran <kdoran@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants