NIFI-9527 Upgrade snappy-java to 1.1.8.4#5760
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-9527 Upgrade snappy-java to 1.1.8.4#5760exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Set managed version in root Maven configuration
Contributor
|
+1 LGTM, verified reading to and writing from a Hive 1.2 table Avro-backed with Snappy compression. Thanks for the upgrade! Merging to main |
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
- Set managed version in root Maven configuration Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#5760
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
- Set managed version in root Maven configuration Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#5760
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
NIFI-9527 Upgrades
snappy-javato 1.1.8.4 for all components using the root Maven configuration. The majority of existing components depend on version 1.1.1.3 or higher. The HBase 1 and HBase 2 client service modules, as well as the Hive 1 module depend on version 1.0.4.1.The snappy-java release notes describe changes between versions. Version 1.1.7.6 made Java 8 the minimum supported version. Version 1.1.2-RC1 notes backward compatibility to 1.0.5. More recent versions support additional native architectures.
This upgrade addresses also addresses compatibility issues when attempting to run NiFi on Java 17.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.