Skip to content

NIFI-9527 Upgrade snappy-java to 1.1.8.4#5760

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9527
Closed

NIFI-9527 Upgrade snappy-java to 1.1.8.4#5760
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9527

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9527 Upgrades snappy-java to 1.1.8.4 for all components using the root Maven configuration. The majority of existing components depend on version 1.1.1.3 or higher. The HBase 1 and HBase 2 client service modules, as well as the Hive 1 module depend on version 1.0.4.1.

The snappy-java release notes describe changes between versions. Version 1.1.7.6 made Java 8 the minimum supported version. Version 1.1.2-RC1 notes backward compatibility to 1.0.5. More recent versions support additional native architectures.

This upgrade addresses also addresses compatibility issues when attempting to run NiFi on Java 17.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Set managed version in root Maven configuration
@exceptionfactory exceptionfactory marked this pull request as ready for review February 15, 2022 21:12
@mattyb149
Copy link
Contributor

+1 LGTM, verified reading to and writing from a Hive 1.2 table Avro-backed with Snappy compression. Thanks for the upgrade! Merging to main

@mattyb149 mattyb149 closed this in 7dfbf99 Feb 15, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
- Set managed version in root Maven configuration

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#5760
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
- Set managed version in root Maven configuration

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#5760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants