NIFI-9722: Do not throw an Exception from verifyCanUpdateProperties w…#5795
Closed
markap14 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-9722: Do not throw an Exception from verifyCanUpdateProperties w…#5795markap14 wants to merge 1 commit intoapache:mainfrom
markap14 wants to merge 1 commit intoapache:mainfrom
Conversation
…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.
gresockj
approved these changes
Feb 24, 2022
Contributor
gresockj
left a comment
There was a problem hiding this comment.
Thanks @markap14, this sounds like a sensible change. I was able to test it out and verify:
- I was still prevented from entering a mixed sensitive value like "password#{abc}"
- I was able to enter a mixed non-sensitive value like "value#{def}" in a processor, and the property was preserved when restarting with the processor ghosted
- NiFi was able to create a ghost processor with a property of the wrong sensitivity, and was simply marked as invalid:
Since this achieves the purpose of the JIRA issue, I'll go ahead and merge this.
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.
Signed-off-by: Joe Gresock <jgresock@gmail.com>
This closes apache#5795.
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.
Signed-off-by: Joe Gresock <jgresock@gmail.com>
This closes apache#5795.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.