Skip to content

NIFI-9722: Do not throw an Exception from verifyCanUpdateProperties w…#5795

Closed
markap14 wants to merge 1 commit intoapache:mainfrom
markap14:NIFI-9722
Closed

NIFI-9722: Do not throw an Exception from verifyCanUpdateProperties w…#5795
markap14 wants to merge 1 commit intoapache:mainfrom
markap14:NIFI-9722

Conversation

@markap14
Copy link
Contributor

…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.
Copy link
Contributor

@gresockj gresockj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markap14, this sounds like a sensible change. I was able to test it out and verify:

  1. I was still prevented from entering a mixed sensitive value like "password#{abc}"
  2. I was able to enter a mixed non-sensitive value like "value#{def}" in a processor, and the property was preserved when restarting with the processor ghosted
  3. NiFi was able to create a ghost processor with a property of the wrong sensitivity, and was simply marked as invalid:

image

Since this achieves the purpose of the JIRA issue, I'll go ahead and merge this.

@asfgit asfgit closed this in 9237b4e Feb 24, 2022
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.

Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes apache#5795.
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
…hen property descriptor & parameter descriptor's sensitivities don't match - instead allow the set to happen and let processor become invalid. Also, allow values such as abc#{param} for ghost processors.

Signed-off-by: Joe Gresock <jgresock@gmail.com>

This closes apache#5795.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants