[NIFI-9746] NiFi Registry Bucket Side Nav no longer fails to open#5831
Merged
Conversation
- all ViewCild queries are decorated with {static: true} which is needed because of new angular version
none of these ViewChild under *ng directives so they are available during init with static:true
Contributor
|
Reviewing now... |
Contributor
|
LGTM! +1 (non-binding). Thanks, @koccs! |
mtien-apache
approved these changes
Mar 3, 2022
Contributor
mtien-apache
left a comment
mtien-apache
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix, @koccs!
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…che#5831) - all ViewCild queries are decorated with {static: true} which is needed because of new angular version none of these ViewChild under *ng directives so they are available during init with static:true Merged apache#5831 into main.
Lehel44
pushed a commit
to Lehel44/nifi
that referenced
this pull request
Jul 1, 2022
…che#5831) - all ViewCild queries are decorated with {static: true} which is needed because of new angular version none of these ViewChild under *ng directives so they are available during init with static:true Merged apache#5831 into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
All ViewChild queries are decorated with
{ static: true }which is needed because of new angular version.None of these ViewChild under
*ngdirectives so they are available during init withstatic:true.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.