NIFI-9788 Updated commons-codec to 1.15 across all modules.#5881
NIFI-9788 Updated commons-codec to 1.15 across all modules.#5881MikeThomsen wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting together this upgrade @MikeThomsen. Upgrading commons-codec across all modules looks like the correct way to go. I noted one question about whether the explicit version number was still necessary in nifi-standard-processors/pom.xml. Otherwise the changes look good.
| <dependency> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.15</version> |
There was a problem hiding this comment.
Is this specific version necessary with the version already specified in the root Maven configuration?
There was a problem hiding this comment.
IIRC it was. I ripped out ALL of them and 4 modules still required it. IIRC, it was due to test vs compile scoping issues with <dependencyManagement> in the root pom.
There was a problem hiding this comment.
Thanks, that makes some sense.
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the upgrade and improvement @MikeThomsen, looks good! +1 merging.
This closes apache#5881 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This closes apache#5881 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This closes apache#5881 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.