Skip to content

NIFI-8124 Added cookie redirect handling to InvokeHTTP#5887

Closed
marcus41495 wants to merge 3 commits intoapache:mainfrom
marcus41495:NIFI-8124
Closed

NIFI-8124 Added cookie redirect handling to InvokeHTTP#5887
marcus41495 wants to merge 3 commits intoapache:mainfrom
marcus41495:NIFI-8124

Conversation

@marcus41495
Copy link
Contributor

@marcus41495 marcus41495 commented Mar 21, 2022

Description of PR

NIFI-8124 Adds support for persistent cookies within the InvokeHTTP processor. Previously, cookies weren't being carried over during redirects. This addition adds a new property "Enable Cookie Redirects", which will create a persistent cookie jar file that will properly handle cookies during HTTP redirects. By default, this is set to false, which will produce the current behavior of the processor.

See https://issues.apache.org/jira/browse/NIFI-8124

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@exceptionfactory exceptionfactory self-requested a review March 21, 2022 22:35
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @marcus41495! This looks like a very useful improvement. The basic approach makes sense, but implementing the new property with potential support for additional values, as opposed to just a Boolean, seems like a more flexible approach.

@exceptionfactory
Copy link
Contributor

Thanks for adjusting the property naming and approach @marcus41495, I will take a closer look at the changes soon.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @marcus41495! Verified runtime behavior works as designed. +1 merging.

asfgit pushed a commit that referenced this pull request Apr 4, 2022
This closes #5887

Signed-off-by: David Handermann <exceptionfactory@apache.org>
genehynson pushed a commit to influxdata/nifi that referenced this pull request May 17, 2022
This closes apache#5887

Signed-off-by: David Handermann <exceptionfactory@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
This closes apache#5887

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Lehel44 pushed a commit to Lehel44/nifi that referenced this pull request Jul 1, 2022
This closes apache#5887

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants