NIFI-9897 Refactor GRPC SSL Configuration#5949
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-9897 Refactor GRPC SSL Configuration#5949exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
f1fc096 to
068cdb5
Compare
- Added SslContextProvider abstracting Netty SslContext configuration - Removed runtime dependency on nifi-security-utils from nifi-grpc-processors - Added TestListenGRPC with methods verifying socket connection and protocol negotiation
068cdb5 to
64d8431
Compare
Contributor
|
Will review.. |
Contributor
|
Sorry Nathan. Didnt see your note. But looks good and merged. |
asfgit
pushed a commit
that referenced
this pull request
Apr 14, 2022
- Added SslContextProvider abstracting Netty SslContext configuration - Removed runtime dependency on nifi-security-utils from nifi-grpc-processors - Added TestListenGRPC with methods verifying socket connection and protocol negotiation Signed-off-by: Joe Witt <joewitt@apache.org>
genehynson
pushed a commit
to influxdata/nifi
that referenced
this pull request
May 17, 2022
- Added SslContextProvider abstracting Netty SslContext configuration - Removed runtime dependency on nifi-security-utils from nifi-grpc-processors - Added TestListenGRPC with methods verifying socket connection and protocol negotiation Signed-off-by: Joe Witt <joewitt@apache.org>
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
- Added SslContextProvider abstracting Netty SslContext configuration - Removed runtime dependency on nifi-security-utils from nifi-grpc-processors - Added TestListenGRPC with methods verifying socket connection and protocol negotiation Signed-off-by: Joe Witt <joewitt@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
NIFI-9897 Refactors the SSL configuration for
InvokeGRPCandListenGRPCto provide better encapsulation of NettySslContextconfiguration.The introduction of the
SslContextProviderclass encapsulates NettySslContextconfiguration using the NiFiSSLContextService.createContext()method. TheSslContextProviderimplementation retains the inferredClientAuthconfiguration based on the presence or absence of a Trust Store in the SSL Context Service.Refactoring the Processors to use the Netty
JdkSslContextclass removes the need fornifi-security-utilsand the transitive dependency on Bouncy Castle, reducing thenifi-grpc-narby several megabytes.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.