Skip to content

NIFI-9897 Refactor GRPC SSL Configuration#5949

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9897
Closed

NIFI-9897 Refactor GRPC SSL Configuration#5949
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-9897

Conversation

@exceptionfactory
Copy link
Contributor

Description of PR

NIFI-9897 Refactors the SSL configuration for InvokeGRPC and ListenGRPC to provide better encapsulation of Netty SslContext configuration.

The introduction of the SslContextProvider class encapsulates Netty SslContext configuration using the NiFi SSLContextService.createContext() method. The SslContextProvider implementation retains the inferred ClientAuth configuration based on the presence or absence of a Trust Store in the SSL Context Service.

Refactoring the Processors to use the Netty JdkSslContext class removes the need for nifi-security-utils and the transitive dependency on Bouncy Castle, reducing the nifi-grpc-nar by several megabytes.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on JDK 8?
  • Have you verified that the full build is successful on JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

- Added SslContextProvider abstracting Netty SslContext configuration
- Removed runtime dependency on nifi-security-utils from nifi-grpc-processors
- Added TestListenGRPC with methods verifying socket connection and protocol negotiation
@thenatog
Copy link
Contributor

Will review..

@joewitt
Copy link
Contributor

joewitt commented Apr 14, 2022

Sorry Nathan. Didnt see your note. But looks good and merged.

@asfgit asfgit closed this in efd2421 Apr 14, 2022
asfgit pushed a commit that referenced this pull request Apr 14, 2022
- Added SslContextProvider abstracting Netty SslContext configuration
- Removed runtime dependency on nifi-security-utils from nifi-grpc-processors
- Added TestListenGRPC with methods verifying socket connection and protocol negotiation

Signed-off-by: Joe Witt <joewitt@apache.org>
genehynson pushed a commit to influxdata/nifi that referenced this pull request May 17, 2022
- Added SslContextProvider abstracting Netty SslContext configuration
- Removed runtime dependency on nifi-security-utils from nifi-grpc-processors
- Added TestListenGRPC with methods verifying socket connection and protocol negotiation

Signed-off-by: Joe Witt <joewitt@apache.org>
krisztina-zsihovszki pushed a commit to krisztina-zsihovszki/nifi that referenced this pull request Jun 28, 2022
- Added SslContextProvider abstracting Netty SslContext configuration
- Removed runtime dependency on nifi-security-utils from nifi-grpc-processors
- Added TestListenGRPC with methods verifying socket connection and protocol negotiation

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants