NIFI-9988 Correct Property Decryption for Authorizers and Providers#6017
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-9988 Correct Property Decryption for Authorizers and Providers#6017exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Updated Protection Scheme Resolver to support both Name matching and Path matching
Contributor
|
Reviewing |
Contributor
|
So with main branch I ran into: and now with this PR it appears fixed. +1 will merge |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2022
- Updated Protection Scheme Resolver to support both Name matching and Path matching Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes #6017.
genehynson
pushed a commit
to influxdata/nifi
that referenced
this pull request
May 17, 2022
- Updated Protection Scheme Resolver to support both Name matching and Path matching Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#6017.
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
- Updated Protection Scheme Resolver to support both Name matching and Path matching Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#6017.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-9988 Corrects Sensitive Property Provider decryption for encrypted property values in
authorizers.xmlandlogin-identity-providers.xml.Refactoring Sensitive Property Providers to use isolated class-loading for NIFI-9883 involved changes to the configuration classes for Authorizers and Login Identity Providers, leveraging the
ProtectionSchemeResolverto determine the Protection Scheme based on the value of theencryptionattribute, such asaes/gcm/256.The
StandardProtectionSchemeResolverworked with the encrypt-config command, which specifies the scheme using one of the known enumerated values, but did not work with the Authorizers or Login Identity Providers configurations, which used the path value. Updating theStandardProtectionSchemeResolverto support resolution based on either the Name or the Path prefix resolves the problem.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-0000NIFI-0000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation