Skip to content

NIFI-9916: ListenTrapSNMP USM parsing refactor.#6034

Closed
Lehel44 wants to merge 6 commits intoapache:mainfrom
Lehel44:NIFI-9916
Closed

NIFI-9916: ListenTrapSNMP USM parsing refactor.#6034
Lehel44 wants to merge 6 commits intoapache:mainfrom
Lehel44:NIFI-9916

Conversation

@Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented May 10, 2022 •
edited
Loading

Summary

  • Refactor ListenTrapSNMP USM user database creation
  • Added more option on the UI to fill USM.
  • Improved USM validation

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@Lehel44 Lehel44 mentioned this pull request May 10, 2022
Closed
13 tasks
nandorsoma
nandorsoma requested changes May 19, 2022
View reviewed changes
Copy link
Contributor

@nandorsoma nandorsoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lehel44!
Thank you for the contribution! I had some comments and questions inline could you check them?

I know it is not part of this PR, but for the first time I didn't understand for what PRIV stands for. I knew from the description that it was related to encryption but it wasn't clear. I needed to check the standard. I'm wondering, wouldn't it be better to use the same naming convention in the description of those values to avoid confusion? (change encryption to privacy) Moreover, wouldn't it make sense to improve the description based on what we can find on this page? https://www.webnms.com/simulator/help/sim_network/netsim_conf_snmpv3.html

@Lehel44 Lehel44 mentioned this pull request May 23, 2022
Closed
12 tasks
@Lehel44
Moved USM reading and validation to customValidate, improved addition…
cfd5415 
…alDetails, property names, default values, dependson.
tpalfy
tpalfy reviewed Jun 29, 2022
View reviewed changes
tpalfy
tpalfy reviewed Jul 4, 2022
View reviewed changes
...snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/utils/UsmJsonParser.java
Comment on lines +37 to +38
MODULE.addDeserializer(UsmUser.class, new UsmUserDeserializer());
MAPPER.registerModule(MODULE);
Copy link
Contributor

@tpalfy tpalfy Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we move the addDeserializer and registerModule into a static initializer?

@asfgit asfgit closed this in 685088a Jul 4, 2022
@tpalfy
Copy link
Contributor

tpalfy commented Jul 4, 2022

LGTM

Thanks for you work @Lehel44!
Pushed to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpalfy tpalfy tpalfy left review comments

@nandorsoma nandorsoma nandorsoma requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lehel44 @tpalfy @nandorsoma