Skip to content

NIFI-10001: Fixed bugs that caused some components to not have their scheduled state updated.#6049

Merged
bbende merged 2 commits intoapache:mainfrom
markap14:NIFI-10001-Part-2
May 18, 2022
Merged

NIFI-10001: Fixed bugs that caused some components to not have their scheduled state updated.#6049
bbende merged 2 commits intoapache:mainfrom
markap14:NIFI-10001-Part-2

Conversation

@markap14
Copy link
Copy Markdown
Contributor

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

markap14 added 2 commits May 18, 2022 11:41
…scheduled state updated. When comparing two flows, now allow specifying how to determine a VersionedComponent's ID for comparison. When comparing local flow against flow from registry, use Versioned Component ID. But when comparing two instantiated flows, such as local flow vs. cluster flow, use the VersionedComponent's Instance ID instead. This ensures that we can properly compare two components even if there are several instances of a given flow
@markap14 markap14 force-pushed the NIFI-10001-Part-2 branch from 5a03196 to 1230a27 Compare May 18, 2022 15:42
Copy link
Copy Markdown
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one system test failure under Java 11 for LB IT which seems unrelated to these changes, going to merge

@bbende bbende merged commit 88e53ea into apache:main May 18, 2022
markap14 added a commit that referenced this pull request May 20, 2022
…scheduled state updated. (#6049)

* NIFI-10001: Fixed issue in which some components may fail to update the scheduled state when comparing flows

* NIFI-10001: Fixed bugs that caused some components to not have their scheduled state updated. When comparing two flows, now allow specifying how to determine a VersionedComponent's ID for comparison. When comparing local flow against flow from registry, use Versioned Component ID. But when comparing two instantiated flows, such as local flow vs. cluster flow, use the VersionedComponent's Instance ID instead. This ensures that we can properly compare two components even if there are several instances of a given flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants