Skip to content

NIFI-10105: FetchS3Object decodes Content-Disposition#6109

Closed
Lehel44 wants to merge 1 commit into
apache:mainfrom
Lehel44:NIFI-10105
Closed

NIFI-10105: FetchS3Object decodes Content-Disposition#6109
Lehel44 wants to merge 1 commit into
apache:mainfrom
Lehel44:NIFI-10105

Conversation

@Lehel44
Copy link
Copy Markdown
Contributor

@Lehel44 Lehel44 commented Jun 8, 2022

Summary

  • PutS3Object sets Content-Disposition HTTP header value URL encoded
  • FetchS3 did not decode the Content-Disposition header
  • Filenames were set encoded

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@asfgit asfgit closed this in 2072e4e Jun 9, 2022
@tpalfy
Copy link
Copy Markdown
Contributor

tpalfy commented Jun 9, 2022

LGTM, merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants