NIFI-10101 Move nifi-hive-nar to optional include-hive profile#6113
NIFI-10101 Move nifi-hive-nar to optional include-hive profile#6113exceptionfactory wants to merge 1 commit into
Conversation
- Added nifi-hive-services-api-nar to include-hive3 and include-hive1_1 profiles
|
@exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38 |
That's a good question @pvillard31! Running a build with optional profiles could place an additional load on standard builds, but it would be helpful to make sure the optional profiles are run on a regular basis. We could create a separate workflow, similar to the system tests, that runs every 24 hours. If you want to create a Jira issue for it, I could take a look at putting together a new GitHub workflow configuration. |
|
I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it? |
That is correct, most of the profiles are limited to controlling what gets included in the assembly. The components and tests are still built as part of the standard ci-workflow. |
Summary
NIFI-10101 Moves the
nifi-hive-narout of the standardnifi-assemblybinary build to an optional profile namedinclude-hive. This approach aligns Hive 1.2 components with other Hive 1.1 and Hive 3 components which are already mapped to the optionalinclude-hive1_1andinclude-hive3profiles.Removing the inclusion of Hive 1.2 components in the default binary build reduces the standard size by 100 MB and also encourages selection of the appropriate version when downloading extension NAR files. All Hive components require the
nifi-hive-services-api-nar, which will be included when building any of the optional profiles.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation