Skip to content

NIFI-10101 Move nifi-hive-nar to optional include-hive profile#6113

Closed
exceptionfactory wants to merge 1 commit into
apache:mainfrom
exceptionfactory:NIFI-10101
Closed

NIFI-10101 Move nifi-hive-nar to optional include-hive profile#6113
exceptionfactory wants to merge 1 commit into
apache:mainfrom
exceptionfactory:NIFI-10101

Conversation

@exceptionfactory
Copy link
Copy Markdown
Contributor

Summary

NIFI-10101 Moves the nifi-hive-nar out of the standard nifi-assembly binary build to an optional profile named include-hive. This approach aligns Hive 1.2 components with other Hive 1.1 and Hive 3 components which are already mapped to the optional include-hive1_1 and include-hive3 profiles.

Removing the inclusion of Hive 1.2 components in the default binary build reduces the standard size by 100 MB and also encourages selection of the appropriate version when downloading extension NAR files. All Hive components require the nifi-hive-services-api-nar, which will be included when building any of the optional profiles.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added nifi-hive-services-api-nar to include-hive3 and include-hive1_1 profiles
@asfgit asfgit closed this in 459daf6 Jun 14, 2022
@pvillard31
Copy link
Copy Markdown
Contributor

@exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38

@exceptionfactory
Copy link
Copy Markdown
Contributor Author

@exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38

That's a good question @pvillard31! Running a build with optional profiles could place an additional load on standard builds, but it would be helpful to make sure the optional profiles are run on a regular basis. We could create a separate workflow, similar to the system tests, that runs every 24 hours. If you want to create a Jira issue for it, I could take a look at putting together a new GitHub workflow configuration.

@pvillard31
Copy link
Copy Markdown
Contributor

I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?

@exceptionfactory
Copy link
Copy Markdown
Contributor Author

I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?

That is correct, most of the profiles are limited to controlling what gets included in the assembly. The components and tests are still built as part of the standard ci-workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants