Skip to content

NIFI-10111: Added option to unpack NARs into an Uber Jar and updated …#6117

Closed
markap14 wants to merge 1 commit into
apache:mainfrom
markap14:NIFI-10111
Closed

NIFI-10111: Added option to unpack NARs into an Uber Jar and updated …#6117
markap14 wants to merge 1 commit into
apache:mainfrom
markap14:NIFI-10111

Conversation

@markap14
Copy link
Copy Markdown
Contributor

…stateless nifi to always use this.

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mattyb149
Copy link
Copy Markdown
Contributor

Reviewing...

nifi.nar.library.autoload.directory=${nifi.nar.library.autoload.directory}
nifi.nar.working.directory=${nifi.nar.working.directory}
nifi.documentation.working.directory=${nifi.documentation.working.directory}
nifi.nar.unpack.uber.jar=${nifi.nar.unpack.uber.jar}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this (also) be added to stateless.properties?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily. With nifi.properties, we tend to offer a lot more properties because it's easy to configure them and because it's a very mature "product." With stateless, this will be important for many cases, and it's going to be hard to expose this in a way that makes sense to most users. I expect this property will go away from NiFi in the future and we'll always do this, but wanted to make it configurable just in case there are any problems. WIth Stateless we take a few more liberties than with NiFi just because it's newer and faster evolving.

@mattyb149
Copy link
Copy Markdown
Contributor

+1 LGTM, tested with stateless and NiFi (with the new property set to true). Everything functioned as expected. Thanks for the improvement! Merging to main

@mattyb149 mattyb149 closed this in 1442dce Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants