NIFI-10111: Added option to unpack NARs into an Uber Jar and updated …#6117
NIFI-10111: Added option to unpack NARs into an Uber Jar and updated …#6117markap14 wants to merge 1 commit into
Conversation
…stateless nifi to always use this.
|
Reviewing... |
| nifi.nar.library.autoload.directory=${nifi.nar.library.autoload.directory} | ||
| nifi.nar.working.directory=${nifi.nar.working.directory} | ||
| nifi.documentation.working.directory=${nifi.documentation.working.directory} | ||
| nifi.nar.unpack.uber.jar=${nifi.nar.unpack.uber.jar} |
There was a problem hiding this comment.
Shouldn't this (also) be added to stateless.properties?
There was a problem hiding this comment.
Not necessarily. With nifi.properties, we tend to offer a lot more properties because it's easy to configure them and because it's a very mature "product." With stateless, this will be important for many cases, and it's going to be hard to expose this in a way that makes sense to most users. I expect this property will go away from NiFi in the future and we'll always do this, but wanted to make it configurable just in case there are any problems. WIth Stateless we take a few more liberties than with NiFi just because it's newer and faster evolving.
|
+1 LGTM, tested with stateless and NiFi (with the new property set to true). Everything functioned as expected. Thanks for the improvement! Merging to main |
…stateless nifi to always use this.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation