Skip to content

NIFI-10130 AzureGraphUserGroupProvider handles nested group#6135

Closed
sjyang18 wants to merge 2 commits intoapache:mainfrom
sjyang18:NIFI-10130
Closed

NIFI-10130 AzureGraphUserGroupProvider handles nested group#6135
sjyang18 wants to merge 2 commits intoapache:mainfrom
sjyang18:NIFI-10130

Conversation

@sjyang18
Copy link
Copy Markdown
Contributor

@sjyang18 sjyang18 commented Jun 17, 2022

Summary

NIFI-10130 This bug fix will retrieves all users under sub groups thru transitivemembers MS graph api.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added one minor comment

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement and addressing the feedback @sjyang18! +1 merging

lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
…members

This closes apache#6135

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants