Skip to content

NIFI-10158 Correct ListFTP expression support for Hostname and Port#6162

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-10158
Closed

NIFI-10158 Correct ListFTP expression support for Hostname and Port#6162
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-10158

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-10158 Corrects ListFTP support for expression language in Hostname and Port properties.

The ListFTP processor declares support for expression language values derived from a variable registry, but property resolution did not perform expression evaluation in StandardFTPClientProvider. ListFTP does not have access to a FlowFile and so provides an empty Map of attributes, whereas other FTP processors provide a Map of attributes from an input FlowFile.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@thenatog
Copy link
Contributor

Tested this with a virtual box FTP server and found that I was able to set variables in my flow and reference these in the ListFTP processor to connect and list files on that server. +1 will merge soon.

@thenatog thenatog closed this in 0458b64 Jun 30, 2022
@greyp9 greyp9 requested review from greyp9 and removed request for greyp9 June 30, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants