NIFI-10224 Move Static Analysis to Separate Workflow Job#6202
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-10224 Move Static Analysis to Separate Workflow Job#6202exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Upgraded multiple GitHub Actions from Version 2 to 3 - Replaced Maven Cache step with cache feature in Setup Java Action - Moved checkstyle and license checks from verify to validate phase in Maven execution - Removed unnecessary contrib-check profile from nifi-registry
greyp9
approved these changes
Jul 18, 2022
Contributor
greyp9
left a comment
greyp9
left a comment
There was a problem hiding this comment.
This all looks great, @exceptionfactory! Nice that the project will now leverage the built-in dependency caching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10224 Moves Maven Checkstyle Plugin and Apache Rat Plugin execution to a separate Static Analysis job in the GitHub continuous integration workflow. This strategy avoids running static analysis in multiple build jobs and also makes it easier to distinguish between different types of workflow failures.
Additional updates include upgrading multiple GitHub Actions from Version 2 to 3 and replacing a separate Maven cache step with Maven caching integrated with the Setup Java Action. Changes also include replacing AdoptOpenJDK with Eclipse Temurin, which is the supported successor to AdoptOpenJDK.
Maven configuration changes include removing an unnecessary duplication
contrib-checkprofile definition in thenifi-registrymodule and changing the Maven phase fromverifytovalidatefor the Checkstyle and Rat Plugins.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation