Skip to content

NIFI-10183 Update Swagger-Annotations to 1.6.6#6208

Closed
mr1716 wants to merge 7 commits intoapache:mainfrom
mr1716:main
Closed

NIFI-10183 Update Swagger-Annotations to 1.6.6#6208
mr1716 wants to merge 7 commits intoapache:mainfrom
mr1716:main

Conversation

@mr1716
Copy link
Contributor

@mr1716 mr1716 commented Jul 14, 2022

Summary

NIFI-10183

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-10183
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-10183

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory changed the title NiFi-10183 Update Swagger-Annotations to 1.6.6 NIFI-10183 Update Swagger-Annotations to 1.6.6 Jul 14, 2022
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade @mr1716, this looks like a good incremental step forward to the latest swagger-annotations version.

Rather than continuing to specify the version number explicitly in each location, this looks like a good opportunity to use dependency management in the root Maven configuration to set the version in one location. That will eliminate the need to set the version in each module. The dependency management configuration for avro in the root pom.xml is a good example to follow. It would also be helpful to squash the commits into a single change when pushing an update. Thanks!

@mr1716
Copy link
Contributor Author

mr1716 commented Aug 8, 2022

@exceptionfactory Ok, thanks. I am not entirely sure how to do that. How would I get that done?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants