NIFI-10183 Update Swagger-Annotations to 1.6.6#6208
Closed
mr1716 wants to merge 7 commits intoapache:mainfrom
mr1716:main
Closed
NIFI-10183 Update Swagger-Annotations to 1.6.6#6208mr1716 wants to merge 7 commits intoapache:mainfrom mr1716:main
mr1716 wants to merge 7 commits intoapache:mainfrom
mr1716:main
Conversation
exceptionfactory
requested changes
Aug 8, 2022
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the upgrade @mr1716, this looks like a good incremental step forward to the latest swagger-annotations version.
Rather than continuing to specify the version number explicitly in each location, this looks like a good opportunity to use dependency management in the root Maven configuration to set the version in one location. That will eliminate the need to set the version in each module. The dependency management configuration for avro in the root pom.xml is a good example to follow. It would also be helpful to squash the commits into a single change when pushing an update. Thanks!
Contributor
Author
|
@exceptionfactory Ok, thanks. I am not entirely sure how to do that. How would I get that done? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10183
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-10183NIFI-10183Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation