Skip to content

NIFI-10249 Enable Parallel Builds in GitHub Workflow#6222

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-10249
Closed

NIFI-10249 Enable Parallel Builds in GitHub Workflow#6222
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-10249

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-10249 Enables parallel builds in GitHub continuous integration workflows. The configuration uses --threads 1C resulting in one thread per CPU core.

Current Ubuntu Linux runners have two cores, macOS runners have three cores, and Windows runners have one core, resulting in different behavior based on each OS.

Additional changes include using a direct GitHub Actions Cache step for Static Analysis to have a cache key different from standard setup-java build steps.

Maven plugin version updates include the following:

  • Upgraded maven-enforcer-plugin from 3.0.0 to 3.1.0
  • Upgraded maven-dependency-plugin from 3.2.0 to 3.3.0
  • Upgraded checkstyle from 9.2.1 to 9.3
  • Upgraded buildnumber-maven-plugin from 1.4 to 3.0.0

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Upgraded maven-enforcer-plugin from 3.0.0 to 3.1.0
- Upgraded maven-dependency-plugin from 3.2.0 to 3.3.0
- Upgraded checkstyle from 9.2.1 to 9.3
- Upgraded buildnumber-maven-plugin from 1.4 to 3.0.0
Copy link
Contributor

@kevdoran kevdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this and making these improvements @exceptionfactory! The changes look good and the CI jobs are passing, so +1, will merge to main.

@kevdoran kevdoran closed this in 8185ad0 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants