NIFI-10249 Enable Parallel Builds in GitHub Workflow#6222
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-10249 Enable Parallel Builds in GitHub Workflow#6222exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Upgraded maven-enforcer-plugin from 3.0.0 to 3.1.0 - Upgraded maven-dependency-plugin from 3.2.0 to 3.3.0 - Upgraded checkstyle from 9.2.1 to 9.3 - Upgraded buildnumber-maven-plugin from 1.4 to 3.0.0
kevdoran
approved these changes
Jul 19, 2022
Contributor
kevdoran
left a comment
There was a problem hiding this comment.
Thanks for noticing this and making these improvements @exceptionfactory! The changes look good and the CI jobs are passing, so +1, will merge to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10249 Enables parallel builds in GitHub continuous integration workflows. The configuration uses
--threads 1Cresulting in one thread per CPU core.Current Ubuntu Linux runners have two cores, macOS runners have three cores, and Windows runners have one core, resulting in different behavior based on each OS.
Additional changes include using a direct GitHub Actions Cache step for Static Analysis to have a cache key different from standard setup-java build steps.
Maven plugin version updates include the following:
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation