NIFI-10240: Removed validation in ListenSyslog on sslContextService a…#6249
Closed
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-10240
Closed
NIFI-10240: Removed validation in ListenSyslog on sslContextService a…#6249emiliosetiadarma wants to merge 1 commit intoapache:mainfrom emiliosetiadarma:NIFI-10240
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-10240
Conversation
…nd made it ignore sslContextService if it is configured while protocol is set to UDP. Also modified tests on processor validation
exceptionfactory
requested changes
Aug 8, 2022
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
After evaluating the fundamental issue, it seems better to avoid removing the custom validation and instead change the user interface behavior. In this scenario, it looks like the UI should continue to display the dependent property, which would allow the user to remove the conflicting setting and resolve the problem.
Contributor
Author
|
Will close the pull request to do the different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd made it ignore sslContextService if it is configured while protocol is set to UDP. Also modified tests on processor validation
Summary
NIFI-10240
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation