NIFI-10305 Fix network and cpu data in c2 heartbeat#6263
Closed
ferencerdei wants to merge 1 commit intoapache:mainfrom
ferencerdei:NIFI-10305_fix_c2_heartbeat_data
Closed
NIFI-10305 Fix network and cpu data in c2 heartbeat#6263ferencerdei wants to merge 1 commit intoapache:mainfrom ferencerdei:NIFI-10305_fix_c2_heartbeat_data
ferencerdei wants to merge 1 commit intoapache:mainfrom
ferencerdei:NIFI-10305_fix_c2_heartbeat_data
Conversation
bejancsaba
approved these changes
Aug 1, 2022
Contributor
bejancsaba
left a comment
There was a problem hiding this comment.
+1, thank you for making this part more robust, we will need to extend the system tests when we get there to have some proper coverage on this as well
pvillard31
approved these changes
Aug 8, 2022
p-kimberley
pushed a commit
to p-kimberley/nifi
that referenced
this pull request
Oct 15, 2022
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#6263.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix the missing network information node in C2 Heartbeat response which happens when the running env has multiple network interfaces and some doesn't have IP assigned to it. Also removing the invalid negative value from the CPU Load average when the running env does not support that command.
NIFI-10305
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation