Skip to content

NIFI-10305 Fix network and cpu data in c2 heartbeat#6263

Closed
ferencerdei wants to merge 1 commit intoapache:mainfrom
ferencerdei:NIFI-10305_fix_c2_heartbeat_data
Closed

NIFI-10305 Fix network and cpu data in c2 heartbeat#6263
ferencerdei wants to merge 1 commit intoapache:mainfrom
ferencerdei:NIFI-10305_fix_c2_heartbeat_data

Conversation

@ferencerdei
Copy link
Contributor

@ferencerdei ferencerdei commented Aug 1, 2022

Summary

This PR fix the missing network information node in C2 Heartbeat response which happens when the running env has multiple network interfaces and some doesn't have IP assigned to it. Also removing the invalid negative value from the CPU Load average when the running env does not support that command.

NIFI-10305

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@bejancsaba bejancsaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you for making this part more robust, we will need to extend the system tests when we get there to have some proper coverage on this as well

@asfgit asfgit closed this in 0fe4d13 Aug 8, 2022
p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#6263.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants