Skip to content

NIFI-10367 update easy-rules-mvel to version 4.1.0#6311

Closed
mr1716 wants to merge 2 commits intoapache:mainfrom
mr1716:main
Closed

NIFI-10367 update easy-rules-mvel to version 4.1.0#6311
mr1716 wants to merge 2 commits intoapache:mainfrom
mr1716:main

Conversation

@mr1716
Copy link
Contributor

@mr1716 mr1716 commented Aug 17, 2022

Summary

NIFI-10367

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade @mr1716, this aligns with the version of easy-rules-mvel in nifi-easyrules-bundle. Taking a closer look at the code in this module, however, it appears to use the mvel2 library directly, without making use of any jeasy classes. Can you update the pull request to remove this dependency completely?

@mr1716
Copy link
Contributor Author

mr1716 commented Aug 17, 2022

@exceptionfactory So instead of updating, so I will remove the dependency completely. Change has been made accordingly to remove the dependency.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @mr1716, verified the absence of jeasy direct and indirect references. +1 merging

p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
…-handler

This closes apache#6311

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants