Skip to content

NIFI-9451 add input character set property for PutEmail and additiona…#6313

Closed
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-9451
Closed

NIFI-9451 add input character set property for PutEmail and additiona…#6313
emiliosetiadarma wants to merge 1 commit intoapache:mainfrom
emiliosetiadarma:NIFI-9451

Conversation

@emiliosetiadarma
Copy link
Contributor

…l tests

Summary

NIFI-9451

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@thenatog
Copy link
Contributor

Will review

@thenatog
Copy link
Contributor

I tested this out, was able to send emails just fine. One thing I had an issue with was other languages. I used Big5 encoding and Chinese characters (http://ash.jp/code/cn/big5tbl.htm) and found that it did come through in the email message content but not in the email attachment. It looks like the character encoding might be getting minced somewhere and might be worth verifying with a unit test.

@thenatog
Copy link
Contributor

Just a note, if you have changes made as a result of a review, commit the change as an additional commit and don't force push. That way the changes made will be tracked in the PR. The committer will merge the commits for you when pushing to main.

@thenatog
Copy link
Contributor

I verified that the change fixed the encoding issue I saw with attached files. I think that should do it, +1 will merge.

@thenatog thenatog closed this in f586f8f Sep 23, 2022
p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
…ional tests

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes apache#6313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants