NIFI-10403 Add processor supporting the new BigQuery Write API#6344
NIFI-10403 Add processor supporting the new BigQuery Write API#6344bejancsaba wants to merge 6 commits intoapache:mainfrom
Conversation
ferencerdei
left a comment
There was a problem hiding this comment.
Thanks for the improved GCP processor. I have some minor comments / suggestions.
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...i-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatch.java
Show resolved
Hide resolved
...p-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryStreaming.java
Show resolved
Hide resolved
@ferencerdei Thanks for taking a look, I addressed your comments. |
ferencerdei
left a comment
There was a problem hiding this comment.
Thanks for the update +1 from my side
arpadboda
left a comment
There was a problem hiding this comment.
Added two minor comments, mostly looks good to me with the latest changes.
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for your work on this new feature @bejancsaba! I noted a number of small recommendations related to logging and error messages. I also raised a question about timestamp conversion, which should not be happening in current versions.
...gcp-processors/src/test/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryBatchIT.java
Outdated
Show resolved
Hide resolved
...in/resources/docs/org.apache.nifi.processors.gcp.bigquery.PutBigQuery/additionalDetails.html
Outdated
Show resolved
Hide resolved
...nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryIT.java
Outdated
Show resolved
Hide resolved
...processors/src/test/java/org/apache/nifi/processors/gcp/bigquery/PutBigQueryStreamingIT.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
...e/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/bigquery/PutBigQuery.java
Outdated
Show resolved
Hide resolved
|
@exceptionfactory thanks for your review I addressed all your comments except one where I added some context / explanation when you have some time please take a look. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the updates @bejancsaba, the latest version looks good. I will defer to @arpadboda for final review.
Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#6344
Summary
NIFI-10403
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation