NIFI-10407 Improve reliability of GetSmbFileTest#6346
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-10407 Improve reliability of GetSmbFileTest#6346exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Changed TestRunner.run() to avoid clearing internal cache between runs - Updated Mockito usage with annotations
Contributor
|
Will review |
Contributor
|
+1 will merge. |
p-kimberley
pushed a commit
to p-kimberley/nifi
that referenced
this pull request
Oct 15, 2022
- Changed TestRunner.run() to avoid clearing internal cache between runs - Updated Mockito usage with annotations Signed-off-by: Nathan Gough <thenatog@gmail.com> This closes apache#6346.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10407 Improves the reliability of
GetSmbFileTest.testBatchSize()usingTestRunner.run()with settings to avoid stopping the processor and clearing the internal queue between invocations within the test method. Additional changes include updating Mockito references to use annotations for mocked objects and introducing lenient expectations for some file operations.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation