Skip to content

NIFI-10409 - adjust nifi-enrich-processors unit tests to handle ISP d…#6348

Closed
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-10409
Closed

NIFI-10409 - adjust nifi-enrich-processors unit tests to handle ISP d…#6348
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-10409

Conversation

@greyp9
Copy link
Contributor

@greyp9 greyp9 commented Aug 29, 2022

…nserrorassist behavior

Leverage MockitoStatic to override test usage of DNS lookup with mocked behavior that aligns with expectations.

Summary

NIFI-10409

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@greyp9
Copy link
Contributor Author

greyp9 commented Aug 29, 2022

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @greyp9, this looks like a good approach to make the test more robust across build environments! +1 merging

p-kimberley pushed a commit to p-kimberley/nifi that referenced this pull request Oct 15, 2022
This closes apache#6348

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants