NIFI-10449: Fix ScriptedLookupServices to reload after disabled and first validation after changes made#6371
Closed
mattyb149 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-10449: Fix ScriptedLookupServices to reload after disabled and first validation after changes made#6371mattyb149 wants to merge 1 commit intoapache:mainfrom
mattyb149 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Will review |
…irst validation after changes made
exceptionfactory
approved these changes
Jan 12, 2023
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the correction @mattyb149, the fix and unit test updates look good. +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10449 This PR fixes an issue where ScriptedLookupService controller services were not reloading at certain times, such as after being disabled with no changes made. This causes things like Parameter value changes not to be picked up. The approach to the fix was basically to do the same as is done with InvokeScriptedProcessor and other scripted controller services.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation