NIFI-10463: Fix GetHubSpot incremental loading#6379
Closed
Lehel44 wants to merge 4 commits intoapache:mainfrom
Closed
NIFI-10463: Fix GetHubSpot incremental loading#6379Lehel44 wants to merge 4 commits intoapache:mainfrom
Lehel44 wants to merge 4 commits intoapache:mainfrom
Conversation
turcsanyip
requested changes
Sep 23, 2022
Contributor
turcsanyip
left a comment
turcsanyip
left a comment
There was a problem hiding this comment.
@Lehel44 I tested the incremental loading functionality and it looks good to me. I also added some comments for improving the documentation and the code.
...-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/resources/META-INF/LICENSE
Show resolved
Hide resolved
nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/resources/META-INF/NOTICE
Outdated
Show resolved
Hide resolved
...i-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/HubSpotObjectType.java
Show resolved
Hide resolved
...i-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/HubSpotObjectType.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...ubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/IncrementalFieldType.java
Outdated
Show resolved
Hide resolved
...ubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/IncrementalFieldType.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Show resolved
Hide resolved
turcsanyip
requested changes
Sep 25, 2022
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
...dle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java
Outdated
Show resolved
Hide resolved
turcsanyip
approved these changes
Sep 26, 2022
Contributor
turcsanyip
left a comment
turcsanyip
left a comment
There was a problem hiding this comment.
@Lehel44 Thanks for the review changes!
+1 LGTM
Merging to main...
p-kimberley
pushed a commit
to p-kimberley/nifi
that referenced
this pull request
Oct 15, 2022
This closes apache#6379. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10463
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation