Skip to content

[NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue. Also update splash screen.#646

Closed
scottyaslan wants to merge 2 commits into
apache:masterfrom
scottyaslan:responsiveDevBranch

Conversation

@scottyaslan
Copy link
Copy Markdown
Contributor

No description provided.

@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch 3 times, most recently from 1701d53 to 88b5b80 Compare July 15, 2016 14:40
@mcgilman
Copy link
Copy Markdown
Contributor

Reviewing...

editor = $('<div></div>').addClass(editorClass).appendTo(wrapper).nfeditor({
languageId: languageId,
width: (cellNode.width() - 5) + 'px',
width: '250px',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to retain the previous behavior where the editor is the width of the entire cell when it's opened.

@scottyaslan scottyaslan changed the title [NIFI-2257] refresh updateattribute processor advanced shell [NIFI-2257] [NIFI-2294] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue Jul 18, 2016
@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch 2 times, most recently from 7d9e4d8 to bc1939e Compare July 19, 2016 18:42
@scottyaslan scottyaslan changed the title [NIFI-2257] [NIFI-2294] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue [NIFI-2257] [NIFI-2294] [NIFI-2287] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue Jul 19, 2016
Scott Aslan added 2 commits July 19, 2016 23:26
@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch from bc1939e to c7a1036 Compare July 20, 2016 04:04
@scottyaslan scottyaslan changed the title [NIFI-2257] [NIFI-2294] [NIFI-2287] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue [NIFI-2257] [NIFI-2294] [NIFI-2287] [NIFI-2270] refresh updateattribute processor advanced shell and fix connection config setting tab scrolling issue. Also update splash screen. Jul 20, 2016
@asfgit asfgit closed this in 8f23afd Jul 20, 2016
@mcgilman
Copy link
Copy Markdown
Contributor

Looks great @scottyaslan! This has been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants