NIFI-10577 Fix Sensitive Checkbox rendering for Fetch Parameters#6473
Merged
mtien-apache merged 2 commits intoapache:mainfrom Oct 3, 2022
Merged
NIFI-10577 Fix Sensitive Checkbox rendering for Fetch Parameters#6473mtien-apache merged 2 commits intoapache:mainfrom
mtien-apache merged 2 commits intoapache:mainfrom
Conversation
- Corrected rendering of Sensitive status checkbox on Firefox using standard nf-checkbox
Contributor
|
Reviewing... |
Contributor
|
Reviewing now |
mcgilman
approved these changes
Oct 3, 2022
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory! I've verified this now runs well in Firefox. Let's wait for @mtien-apache to review and then let's merge.
Contributor
Author
|
Further testing in Safari resulted in the NiFi Canvas not rendering. I pushed an update adding |
mtien-apache
approved these changes
Oct 3, 2022
Contributor
mtien-apache
left a comment
mtien-apache
left a comment
There was a problem hiding this comment.
Good catch! Your latest changes fix the issue. Verified that it works as expected in Firefox, Safari, and Chrome. Thanks!
p-kimberley
pushed a commit
to p-kimberley/nifi
that referenced
this pull request
Oct 15, 2022
…che#6473) * NIFI-10577 Fixed Sensitive Checkbox rendering for Fetch Parameters - Corrected rendering of Sensitive status checkbox on Firefox using standard nf-checkbox * NIFI-10577 Corrected canvas rendering in Safari Merged apache#6473 in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10577 Fixes the Sensitive status checkbox rendering on Firefox in the Fetch Parameters dialog for Parameter Providers.
Changes include replacing the input elements and
:beforepseudo-element selectors with thenf-checkboxstyling approached used in other components.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation