NIFI-2087: Do not update the lucene index to delete expired events...#652
Closed
markap14 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2087: Do not update the lucene index to delete expired events...#652markap14 wants to merge 1 commit intoapache:masterfrom
markap14 wants to merge 1 commit intoapache:masterfrom
Conversation
…nstead, just wait for the entire index to expire and remove the files for that index. This is much more efficient.
Contributor
|
Reviewing |
Contributor
|
I see this change only taking effect when the repo is initialized. Is there really no other place that should be updated? |
Contributor
Author
|
@JPercivall no, that should be it. We have one other place where we use the DeleteFileAction but it still needs to stay there. This should take care of it. |
Contributor
|
+1 Did a contrib check build, visually verified and ran a lot of data with a small index size and saw it work as expected. Will merge in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, just wait for the entire index to expire and remove the files for that index. This is much more efficient.