Skip to content

NIFI-10704 - include API name of properties in processor documentation#6586

Closed
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-10704
Closed

NIFI-10704 - include API name of properties in processor documentation#6586
greyp9 wants to merge 1 commit intoapache:mainfrom
greyp9:NIFI-10704

Conversation

@greyp9
Copy link
Contributor

@greyp9 greyp9 commented Oct 27, 2022

Summary

NIFI-10704

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@thenatog
Copy link
Contributor

Will review

@mattyb149
Copy link
Contributor

Since this is supposed to be a machine-friendly name, I wonder if we should put it as the last column so it doesn't make the user-friendly information "noisy". @andrewmlim Thoughts?

@andrewmlim
Copy link
Contributor

@mattyb149 I understand the concern, but I think the way @greyp9 implemented is good. I think Display Name and API Name should be grouped together and since Description typically takes up a lot of space, the API Name column could get lost if placed as the last column.

@exceptionfactory
Copy link
Contributor

@ottobackwards The REST API provides the information, but providing it in the generated documentation makes it more accessible when writing integrations. The internal property names are effectively final once released, so publishing them in the generated component documentation seems reasonable and useful.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my perspective, but I will defer to others for final review and approval.

@ottobackwards
Copy link
Contributor

@exceptionfactory yeah, I was just thinking about the difference between developer documentation and UI/user documentation. What would be nice would be if there was a second additional details page that had the config dto as json and documented for developers, or that the rest api could provide a get_default_configuration for processors and controllers

@mattyb149
Copy link
Contributor

+1 LGTM, appreciate the discussion! Thanks for the improvement, merging to main

@mattyb149 mattyb149 closed this Oct 28, 2022
mattyb149 pushed a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #6586
priyanka-28 pushed a commit to priyanka-28/nifi that referenced this pull request Nov 16, 2022
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#6586
lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#6586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants