NIFI-10704 - include API name of properties in processor documentation#6586
NIFI-10704 - include API name of properties in processor documentation#6586greyp9 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Will review |
|
Since this is supposed to be a machine-friendly name, I wonder if we should put it as the last column so it doesn't make the user-friendly information "noisy". @andrewmlim Thoughts? |
|
@mattyb149 I understand the concern, but I think the way @greyp9 implemented is good. I think Display Name and API Name should be grouped together and since Description typically takes up a lot of space, the API Name column could get lost if placed as the last column. |
|
@ottobackwards The REST API provides the information, but providing it in the generated documentation makes it more accessible when writing integrations. The internal property names are effectively final once released, so publishing them in the generated component documentation seems reasonable and useful. |
exceptionfactory
left a comment
There was a problem hiding this comment.
+1 from my perspective, but I will defer to others for final review and approval.
|
@exceptionfactory yeah, I was just thinking about the difference between developer documentation and UI/user documentation. What would be nice would be if there was a second additional details page that had the config dto as json and documented for developers, or that the rest api could provide a get_default_configuration for processors and controllers |
|
+1 LGTM, appreciate the discussion! Thanks for the improvement, merging to main |
Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes #6586
Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#6586
Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#6586
Summary
NIFI-10704
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation