NIFI-8497: implemented SlackRecordSink and Test, wrote documentation …#6593
NIFI-8497: implemented SlackRecordSink and Test, wrote documentation …#6593emiliosetiadarma wants to merge 10 commits intoapache:mainfrom emiliosetiadarma:NIFI-8497
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the contribution @emiliosetiadarma, this looks like a useful addition.
Although the new SlackRecordSink follows a similar pattern as the existing Slack components, this is an opportunity to move away from the javax.json and Apache HttpClient libraries. Instead, the Jackson JSON library should be used, along with the WebServiceClientProvider and nifi-web-client-api, which provides an abstraction around HTTP client operations. Eventually the other Slack components should be refactored along the same lines, but that can be handled separately. As this is a new component, it should make use of these features.
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/pom.xml
Outdated
Show resolved
Hide resolved
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/pom.xml
Outdated
Show resolved
Hide resolved
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/pom.xml
Outdated
Show resolved
Hide resolved
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/pom.xml
Outdated
Show resolved
Hide resolved
...ndle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRecordSink.java
Outdated
Show resolved
Hide resolved
...ndle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRecordSink.java
Outdated
Show resolved
Hide resolved
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the updates @emiliosetiadarma, I noted a few more recommendations, but this looks close to completion.
...-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackPostMessageResponse.java
Outdated
Show resolved
Hide resolved
...slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/Message.java
Outdated
Show resolved
Hide resolved
...slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/Message.java
Outdated
Show resolved
Hide resolved
...slack-bundle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/Message.java
Outdated
Show resolved
Hide resolved
...ndle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRecordSink.java
Outdated
Show resolved
Hide resolved
...dle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRestService.java
Outdated
Show resolved
Hide resolved
...dle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRestService.java
Outdated
Show resolved
Hide resolved
...dle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRestService.java
Outdated
Show resolved
Hide resolved
...dle/nifi-slack-processors/src/main/java/org/apache/nifi/services/slack/SlackRestService.java
Outdated
Show resolved
Hide resolved
...ifi-slack-processors/src/main/java/org/apache/nifi/services/slack/TimestampDeserializer.java
Outdated
Show resolved
Hide resolved
...ifi-slack-processors/src/main/java/org/apache/nifi/services/slack/TimestampDeserializer.java
Outdated
Show resolved
Hide resolved
…in CapabilityDescription of SlackRecordSink
…ncies to provided, implemented SlackRestService and refactored to use Jackson and WebClientServiceProvider
…lack Response object model
…endZeroResults when deciding whether to send empty message to Slack
|
Thanks for making the updates @emiliosetiadarma, I pushed one more commit to remove the Message and Attachment model classes, since they were not used in any of the service classes. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Merging following successful builds. Thanks for the work on this feature @emiliosetiadarma!
This closes apache#6593 Signed-off-by: David Handermann <exceptionfactory@apache.org>
…in CapabilityDescription of SlackRecordSink
Summary
NIFI-8497
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation