Skip to content

NIFI-8497: implemented SlackRecordSink and Test, wrote documentation …#6593

Closed
emiliosetiadarma wants to merge 10 commits intoapache:mainfrom
emiliosetiadarma:NIFI-8497
Closed

NIFI-8497: implemented SlackRecordSink and Test, wrote documentation …#6593
emiliosetiadarma wants to merge 10 commits intoapache:mainfrom
emiliosetiadarma:NIFI-8497

Conversation

@emiliosetiadarma
Copy link
Contributor

@emiliosetiadarma emiliosetiadarma commented Oct 27, 2022

…in CapabilityDescription of SlackRecordSink

Summary

NIFI-8497

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @emiliosetiadarma, this looks like a useful addition.

Although the new SlackRecordSink follows a similar pattern as the existing Slack components, this is an opportunity to move away from the javax.json and Apache HttpClient libraries. Instead, the Jackson JSON library should be used, along with the WebServiceClientProvider and nifi-web-client-api, which provides an abstraction around HTTP client operations. Eventually the other Slack components should be refactored along the same lines, but that can be handled separately. As this is a new component, it should make use of these features.

@thenatog thenatog added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 28, 2022
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates @emiliosetiadarma, I noted a few more recommendations, but this looks close to completion.

@exceptionfactory
Copy link
Contributor

Thanks for making the updates @emiliosetiadarma, I pushed one more commit to remove the Message and Attachment model classes, since they were not used in any of the service classes.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging following successful builds. Thanks for the work on this feature @emiliosetiadarma!

r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
This closes apache#6593

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants