Skip to content

NIFI-10718 Update mongo.driver.version to 4.7.2#6599

Closed
UcanInfosec wants to merge 1 commit intoapache:mainfrom
UcanInfosec:main
Closed

NIFI-10718 Update mongo.driver.version to 4.7.2#6599
UcanInfosec wants to merge 1 commit intoapache:mainfrom
UcanInfosec:main

Conversation

@UcanInfosec
Copy link
Copy Markdown
Contributor

Summary

NIFI-10718

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@MikeThomsen
Copy link
Copy Markdown
Contributor

@UcanInfosec for the kind of updates you do, there's nothing wrong with you pushing a PR that has multiple Jira tickets in it to save time on creating and reviewing the PR.

@UcanInfosec
Copy link
Copy Markdown
Contributor Author

@MikeThomsen thanks, much appreciated. Will look into that. But dont want to complicate things and make things harder for everyone.

@exceptionfactory
Copy link
Copy Markdown
Contributor

@MikeThomsen Just a note, although it creates more tickets, it is helpful to keep the updates focused on a single dependency, or directly related group of dependencies. Updating different types can create confusion and make it more difficult to review. It is a case-by-case question, but in general, I think it is better to keep the updates limited for easier review and tracking.

@UcanInfosec
Copy link
Copy Markdown
Contributor Author

When I ran the actions locally, the pull request ran successfully. The JDK11 failure might need to be run again

@MikeThomsen
Copy link
Copy Markdown
Contributor

@exceptionfactory

Just a note, although it creates more tickets

To be clear, I said @UcanInfosec can push multiple Jira tickets in the same PR. When doing these bulk updates of dependencies, it would make more sense for @UcanInfosec/@mr1716 to do a big PR that has multiple commits, one for each Jira ticket.

@exceptionfactory
Copy link
Copy Markdown
Contributor

Thanks for clarifying @MikeThomsen, that makes sense. Depending on the scope of the changes, we still should be careful in terms of how many changes to include in a single PR, but I agree that some updates could be grouped together.

@UcanInfosec
Copy link
Copy Markdown
Contributor Author

@MikeThomsen @exceptionfactory Thanks. Will do. After this is merged, I will ramp it down for PR requests and commits going forward for a while.

@asfgit asfgit closed this in 557a1a7 Oct 28, 2022
priyanka-28 pushed a commit to priyanka-28/nifi that referenced this pull request Nov 16, 2022
This closes apache#6599

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
This closes apache#6599

Signed-off-by: Mike Thomsen <mthomsen@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants