Skip to content

NIFI-10723 - Added extra exception message to PostHTTP for when clien… #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thenatog wants to merge 1 commit into from
Closed

NIFI-10723 - Added extra exception message to PostHTTP for when clien… #6602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .../nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import org.apache.http.NoHttpResponseException;
import org.apache.http.auth.AuthScope;
import org.apache.http.auth.UsernamePasswordCredentials;
import org.apache.http.client.ClientProtocolException;
import org.apache.http.client.CredentialsProvider;
import org.apache.http.client.HttpRequestRetryHandler;
import org.apache.http.client.config.RequestConfig;
Expand Down Expand Up @@ -546,7 +547,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
firstFlowFile = session.penalize(firstFlowFile);
session.transfer(firstFlowFile, REL_FAILURE);
logger.error("Unable to communicate with destination {} to determine whether or not it can accept "
+ "flowfiles/gzip; routing {} to failure due to {}", new Object[]{url, firstFlowFile, e});
+ "flowfiles/gzip; routing {} to failure due to {}", url, firstFlowFile, e);
return;
}
}
Expand Down Expand Up @@ -877,7 +878,12 @@ private DestinationAccepts getDestinationAcceptance(final boolean sendAsFlowFile
head.addHeader(TRANSACTION_ID_HEADER, transactionId);
}

final HttpResponse response = client.execute(head, httpContext);
final HttpResponse response;
try {
response = client.execute(head, httpContext);
} catch (ClientProtocolException e) {
throw new ClientProtocolException("Remote may be expecting HTTPS connection", e);
}

// we assume that the destination can support FlowFile v1 always when the processor is also configured to send as a FlowFile
// otherwise, we do not bother to make any determinations concerning this compatibility
Expand Down