NIFI-10774 fix flaky tests in TestGetHDFSFileInfo#6629
Closed
YiweiLi4 wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-10774 fix flaky tests in TestGetHDFSFileInfo#6629YiweiLi4 wants to merge 2 commits intoapache:mainfrom
YiweiLi4 wants to merge 2 commits intoapache:mainfrom
Conversation
pvillard31
reviewed
Dec 25, 2022
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
I'd try to achieve the same without introducing an additional dependency. Or at the very least, change the scope of the dependency for testing only.
Contributor
|
@YiweiLi4 Thanks for the contribution, as previously these test changes should be implemented without the additional dependency. I am closing this pull request for now, but feel free to follow up after making the requested changes when you are ready for further review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10774
testRecursiveGroupAllToAttributesis detected flaky by Nondex since the attribute "hdfs.full.tree" is a JSON Object and is not always written in a deterministic order. Instead of comparing the string of the attribute and the expected one, I usedjsonassertto compare the two JSON objects.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation