NIFI-10875 fixed flaky test

[ycliu28]

Summary

NIFI-10875

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 8
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for the contribution @tt0suzy. Instead of changing the test to use the inline conditional, a better approach would be to assert the presence of the individual key=value parameters. That would avoid depending on parameter order while keeping the test clear.

[ycliu28]

Hi @exceptionfactory, are you suggesting something like

String querySrting = attributes.get(QuerySolr.ATTRIBUTE_SOLR_QUERY)
//"q=*:*&qt=/select&start=0&rows=10&stats=true&facet=true"
assertTrue(queryString.contains("q=*:*") && queryString.contains("qt=/select") && querystring.contains("start=0") && queryString.contains("rows=10") && queryString.contains("stats=true") && queryString.contains("facet=true"));

[exceptionfactory]

Hi @exceptionfactory, are you suggesting something like

String querySrting = attributes.get(QuerySolr.ATTRIBUTE_SOLR_QUERY)
//"q=*:*&qt=/select&start=0&rows=10&stats=true&facet=true"
assertTrue(queryString.contains("q=*:*") && queryString.contains("qt=/select") && querystring.contains("start=0") && queryString.contains("rows=10") && queryString.contains("stats=true") && queryString.contains("facet=true"));

Thanks for the reply @tt0suzy. Yes, that is the basic idea. Instead of multiple queryString.contains() calls with in one assertTrue. Having one assert per check would be helpful to keep the code clear:

assertTrue(queryString.contains("q=*:*"));
assertTrue(queryString.contains("qt=/select"));
...

[ycliu28]

Updated, thanks for the advice.

[exceptionfactory]

Thanks for making the changes @tt0suzy, the latest version looks good. +1 merging