NIFI-10890 Change HashMap to LinkedHashMap in AbstractJsonRowRecordReader.createRecordFromRawValue for deterministic handling#6726
Closed
sopan98 wants to merge 2 commits intoapache:mainfrom
Conversation
…rdFieldOrderPreserved
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the improvement @sopan98. The change itself looks good. There are a couple other uses of HashMap in AbstractJsonRowRecordReader, so this seems like a good opportunity to replace all of them with LinkedHashMap to avoid potential future issues.
Contributor
Author
|
@exceptionfactory I have changed every |
exceptionfactory
approved these changes
Nov 29, 2022
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @sopan98! +1 merging
asfgit
pushed a commit
that referenced
this pull request
Nov 30, 2022
- Updated unit test based on deterministic behavior of LinkedHashMap This closes #6726 Signed-off-by: David Handermann <exceptionfactory@apache.org>
lizhizhou
pushed a commit
to lizhizhou/nifi
that referenced
this pull request
Jan 2, 2023
- Updated unit test based on deterministic behavior of LinkedHashMap This closes apache#6726 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10890
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation