NIFI-10966: Add option to QuerySalesforceObject to run custom query#6794
Closed
Lehel44 wants to merge 6 commits intoapache:mainfrom
Closed
NIFI-10966: Add option to QuerySalesforceObject to run custom query#6794Lehel44 wants to merge 6 commits intoapache:mainfrom
Lehel44 wants to merge 6 commits intoapache:mainfrom
Conversation
tpalfy
reviewed
Jan 13, 2023
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
Contributor
|
Hi - I've been playing with this and it works as expected (except that SOQL is super hard to understand...). One improvement I'd like to see is that the processor should accept input relationships (optional - a bit like ExecuteSQL) and the custom SOQL query should be able to reference flow file attributes. This would give me the option to potentially chain multiple instances together in a flow definition. |
Contributor
|
I've been playing with the latest version and this is working as expected. I'm a +1 from a feature usage point of view. |
pvillard31
approved these changes
Feb 16, 2023
tpalfy
reviewed
Feb 16, 2023
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Outdated
Show resolved
Hide resolved
...rces/docs/org.apache.nifi.processors.salesforce.QuerySalesforceObject/additionalDetails.html
Outdated
Show resolved
Hide resolved
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Show resolved
Hide resolved
tpalfy
reviewed
Feb 23, 2023
...ce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java
Show resolved
Hide resolved
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2023
This closes #6794. Signed-off-by: Tamas Palfy <tpalfy@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-10966
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation