NIFI-2319: Ensure that when we set cluster node id's and node address…#680
Closed
markap14 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2319: Ensure that when we set cluster node id's and node address…#680markap14 wants to merge 1 commit intoapache:masterfrom
markap14 wants to merge 1 commit intoapache:masterfrom
Conversation
…es, that we do so only if they are not already populated
Contributor
|
+1 Visually verified code and did a contrib check build. I built a secure 3 node cluster and tested various different logic paths related to viewing/emptying the queue and they all worked as expected. Thanks @markap14, I will merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es, that we do so only if they are not already populated