Skip to content

NIFI-11004 Add documentation for OIDC groups claim property#6802

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11004
Closed

NIFI-11004 Add documentation for OIDC groups claim property#6802
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11004

Conversation

@exceptionfactory
Copy link
Copy Markdown
Contributor

Summary

NIFI-11004 Updates the Administrator's Guide with documentation for the OIDC groups claim property and also updates the standard nifi.properties configuration with the default value of groups, matching the current internal behavior.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@Lehel44 Lehel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the documentation @exceptionfactory. Why do we need to update nifi-resources.pom?

Comment on lines +507 to +508
user is a member. Application groups must be supplied from a User Group Provider with matching names in order for the
authorization process to use ID token claim groups. The default value is `groups`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user is a member. Application groups must be supplied from a User Group Provider with matching names in order for the
authorization process to use ID token claim groups. The default value is `groups`.
user is a member. Application groups must be supplied by a User Group Provider with matching names for the
authorization process to use ID token claim groups. The default value is `groups`.

@exceptionfactory
Copy link
Copy Markdown
Contributor Author

Why do we need to update nifi-resources.pom?

Thanks for the feedback @Lehel44. The updates to pom.xml in nifi-resources sets the default value for the nifi.properties configuration included in the standard distribution. This follows the convention of other default property values, and also allows custom builds to set different default values using Maven properties.

@Lehel44
Copy link
Copy Markdown
Contributor

Lehel44 commented Dec 24, 2022

Thank you. LGTM+1

@greyp9 greyp9 self-requested a review January 9, 2023 19:46
Copy link
Copy Markdown
Contributor

@greyp9 greyp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greyp9 greyp9 closed this in 0c0f7e8 Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants