Skip to content

NIFI-11147: Query all fields in QuerySalesforceObject#6960

Closed
Lehel44 wants to merge 2 commits intoapache:mainfrom
Lehel44:NIFI-11147
Closed

NIFI-11147: Query all fields in QuerySalesforceObject#6960
Lehel44 wants to merge 2 commits intoapache:mainfrom
Lehel44:NIFI-11147

Conversation

@Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Feb 15, 2023

Summary

NIFI-11147

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@krisztina-zsihovszki krisztina-zsihovszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lehel44 for this improvement, checked with BusinessBrand object, it works fine, returns all the fields.
Added just minor comments to the PR.

@mattyb149
Copy link
Contributor

+1 LGTM, verified the property is now optional and leaving it empty causes all available fields to be queried. Thanks for the improvement! Merging to main

@mattyb149 mattyb149 closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants