NIFI-11191 Refactored HikariCPConnectionPoolTest with Mock Driver#6966
Merged
kevdoran merged 1 commit intoapache:mainfrom Feb 16, 2023
Merged
NIFI-11191 Refactored HikariCPConnectionPoolTest with Mock Driver#6966kevdoran merged 1 commit intoapache:mainfrom
kevdoran merged 1 commit intoapache:mainfrom
Conversation
- Removed Derby dependencies from HikariCP module no longer required for testing
kevdoran
approved these changes
Feb 16, 2023
Contributor
kevdoran
left a comment
kevdoran
left a comment
There was a problem hiding this comment.
+1, will merge once the last CI build completes
udaynpusa
pushed a commit
to mapr/nifi
that referenced
this pull request
Apr 25, 2024
…ache#6966) - Removed Derby dependencies from HikariCP module no longer required for testing Signed-off-by: Kevin Doran <kdoran@apache.org> (cherry picked from commit 5507bfa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11191 Refactors the
HikariCPConnectionPoolTestclass using aMockDriverclass to avoid intermittent failures related to concurrency and file locking when using Apache Derby.The existing test class attempted to work around locking issues using specialized temporary file handling for the Derby database and associated the logs. The
MockDriverapproach avoids these issues and focuses the test on confirming whether the Controller Service returns a Connection.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation