Skip to content

NIFI-11281 Correct Accumulo NAR dependencies#7042

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11281
Closed

NIFI-11281 Correct Accumulo NAR dependencies#7042
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11281

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-11281 Corrects the scope of accumulo-core in for the Processors NAR and Services NAR modules under nifi-accumulo-bundle. Setting the scope to provided allows the Accumulo NAR modules to use accumulo-core from nifi-accumulo-services-api-nar and eliminates over 70 MB from each of the dependent NAR files.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Set accumulo-core to provided in NAR and Services NAR modules
- Removed unused dependencies
@asfgit asfgit closed this in 5b9fabb Mar 14, 2023
@pvillard31
Copy link
Contributor

@exceptionfactory - this does not apply cleanly to 1.x branch, only applied to main

@exceptionfactory
Copy link
Contributor Author

Thanks @pvillard31, I will review it and evaluate the changes necessary for backporting.

exceptionfactory added a commit that referenced this pull request Mar 14, 2023
- Set accumulo-core to provided in NAR and Services NAR modules
- Removed unused dependencies

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7042.
r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
- Set accumulo-core to provided in NAR and Services NAR modules
- Removed unused dependencies

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#7042.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants