NIFI-11290: Ensure that components are notified that primary node has…#7052
Closed
markap14 wants to merge 2 commits into
Closed
NIFI-11290: Ensure that components are notified that primary node has…#7052markap14 wants to merge 2 commits into
markap14 wants to merge 2 commits into
Conversation
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the improvements @markap14. The general approach looks good, moving the primary node state change handling to a separate thread should definitely make the framework more robust when encountering components that do not behave during those state changes.
The new system test is helpful, but it looks like it is subject to a timing problem, resulting in failures on both Ubuntu 11 and 17. Should the test include a wait for the node to become disconnected before attempting to reconnect it?
… changed in a background thread instead of the Leader Election thread and activate/deactivate the thread in the case of Processors so that they can be viewed in the UI and terminated
… they did not wait for node disconnection to complete and did not properly switch the client to look at the connected node before checking cluster status
exceptionfactory
approved these changes
Mar 23, 2023
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for updating the system tests @markap14. Runtime testing with basic triggering of primary node state changes also looks good. +1 merging
exceptionfactory
pushed a commit
that referenced
this pull request
Mar 23, 2023
- Ensure that components are notified that primary node has changed in a background thread instead of the Leader Election thread and activate/deactivate the thread in the case of Processors so that they can be viewed in the UI and terminated - Fixed system tests that would fail intermittently because they did not wait for node disconnection to complete and did not properly switch the client to look at the connected node before checking cluster status This closes #7052 Signed-off-by: David Handermann <exceptionfactory@apache.org>
r-vandenbos
pushed a commit
to r-vandenbos/nifi
that referenced
this pull request
Apr 11, 2023
- Ensure that components are notified that primary node has changed in a background thread instead of the Leader Election thread and activate/deactivate the thread in the case of Processors so that they can be viewed in the UI and terminated - Fixed system tests that would fail intermittently because they did not wait for node disconnection to complete and did not properly switch the client to look at the connected node before checking cluster status This closes apache#7052 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… changed in a background thread instead of the Leader Election thread and activate/deactivate the thread in the case of Processors so that they can be viewed in the UI and terminated
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation