Skip to content

NIFI-11323: Fixed last modified change detection of dynamicallyModifi…#7069

Merged
markap14 merged 1 commit intoapache:mainfrom
turcsanyip:NIFI-11323
Mar 22, 2023
Merged

NIFI-11323: Fixed last modified change detection of dynamicallyModifi…#7069
markap14 merged 1 commit intoapache:mainfrom
turcsanyip:NIFI-11323

Conversation

@turcsanyip
Copy link
Copy Markdown
Contributor

@turcsanyip turcsanyip commented Mar 21, 2023

…esClasspath resources

Summary

NIFI-11323

All URLs were treated as file URLs which led to java.lang.IllegalArgumentException: URI scheme is not "file"

Last modified time is checked for file:// URLs. No change detection for http(s):// URLs.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@markap14
Copy link
Copy Markdown
Contributor

Thanks @turcsanyip this looks like a reasonable change and eliminates a rather specific assumption that won't always be true. +1 will merge.

@markap14 markap14 merged commit 00707f6 into apache:main Mar 22, 2023
markap14 pushed a commit that referenced this pull request Mar 22, 2023
r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants