NIFI-11319 Fixing TestStatelessBootstrap::testClassNotAllowed#7070
Merged
Conversation
Contributor
|
Thanks @simonbence that does appear to address the issue. Interestingly, I didn't encounter it when running |
markap14
pushed a commit
that referenced
this pull request
Mar 22, 2023
r-vandenbos
pushed a commit
to r-vandenbos/nifi
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was broken. My understaning is that the test supposed to ensure that classes from outside the allowed NAR directory should not be loaded expect if they are part of a spefic set of classes (java or jdk "modules"). The original configuration of the test used the "target" folder as NAR folder, which contained every product of the build, including the class "org.apache.nifi.stateless.bootstrap.RunStatelessFlow" used as test subject, thus the class was loaded and the test broke. I narrowed down the "nar folder" in order to not have the test subject included, this I would believe solves the issue.
NIFI-11319
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation