Skip to content

NIFI-11325 Upgraded Mockito from 3.12.4 to 4.11.0#7071

Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-11325
Closed

NIFI-11325 Upgraded Mockito from 3.12.4 to 4.11.0#7071
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-11325

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-11325 Upgrades Mockito from 3.12.4 to 4.11.0 and updates deprecated references to current methods.

Mockito 4 provides the current baseline version for Java 8, which works for both the NiFi current main branch and the support branch. Subsequent efforts can evaluate upgrading the main branch to Mockito 5, which requires Java 11.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Replaced deprecated Matchers references with ArgumentMatchers
- Removed unnecessary Mockito versions for Registry
@asfgit asfgit closed this in 8154fcc Mar 23, 2023
asfgit pushed a commit that referenced this pull request Mar 23, 2023
- Replaced deprecated Matchers references with ArgumentMatchers
- Removed unnecessary Mockito versions for Registry
- Refactored test configuration to Java for mocking

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes #7071.
r-vandenbos pushed a commit to r-vandenbos/nifi that referenced this pull request Apr 11, 2023
- Replaced deprecated Matchers references with ArgumentMatchers
- Removed unnecessary Mockito versions for Registry
- Refactored test configuration to Java for mocking

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#7071.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants