Skip to content

NIFI-11363 Fix precision number handling in Flow Encryption Commands#7101

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11363
Closed

NIFI-11363 Fix precision number handling in Flow Encryption Commands#7101
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-11363

Conversation

@exceptionfactory
Copy link
Copy Markdown
Contributor

Summary

NIFI-11363 Corrects handling of double precision numbers in flow encryption commands including encrypt-config.sh, set-sensitive-properties-key, and set-sensitive-properties-algorithm.

The JSON parsing process used a method to return a Java float value when encountering the JSON VALUE_NUMBER_FLOAT type, which resulted in loss of precision under certain circumstances, such as position coordinates for Processors.

The correction returns the parsed value as a string and uses the writeRawValue() method to avoid any number conversion while processing values.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@simonbence
Copy link
Copy Markdown
Contributor

Reviewing

@simonbence
Copy link
Copy Markdown
Contributor

LGTM, I also validated the change

@joewitt joewitt closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants