NIFI-11363 Fix precision number handling in Flow Encryption Commands#7101
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-11363 Fix precision number handling in Flow Encryption Commands#7101exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Reviewing |
Contributor
|
LGTM, I also validated the change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11363 Corrects handling of double precision numbers in flow encryption commands including
encrypt-config.sh,set-sensitive-properties-key, andset-sensitive-properties-algorithm.The JSON parsing process used a method to return a Java
floatvalue when encountering the JSONVALUE_NUMBER_FLOATtype, which resulted in loss of precision under certain circumstances, such as position coordinates for Processors.The correction returns the parsed value as a string and uses the
writeRawValue()method to avoid any number conversion while processing values.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation